On Thu, Jul 10, 2003 at 04:59:39PM -0700, Remco Treffkorn wrote: > Ethan, > > The good news is that I now know a little more about powerpc assembly. > The bad news is that the problem was not in the varargs implementation, but > its use. > > You used to call vsnprintf twice. Once to find out how much buffer would be > needed, then the second time for real. You can't do that without reseting ap. ah right, i fixed this issue in vasprintf() some time ago. > The appended patch proposes a fix. > Btw: You said you'd tested that with LD_PRELOAD? What happend? vfprintf is blacklisted from prom-libc.so since the FILE stuff interferes with glibc. (pretty much all of stdio is blacklisted, thats what the SOOBJS is in the Rules files). > --- /tmp/yaboot-1.99.x/lib/libc/stdio/vfprintf.c 2003-03-08 22:57:36.000000000 > -0800 > +++ stdio/vfprintf.c 2003-07-10 16:43:20.000000000 -0700 im fixing it differently since i don't want a large buf array around persistently -- Ethan Benson http://www.alaska.net/~erbenson/
Attachment:
pgp00020.pgp
Description: PGP signature