Re: vfprintf.c bugfix

[Remco Treffkorn <remco@rvt.com>]

On Friday 11 July 2003 01:37, Ethan Benson wrote:
> On Thu, Jul 10, 2003 at 04:59:39PM -0700, Remco Treffkorn wrote:
> > Ethan,
> >
> > The good news is that I now know a little more about powerpc assembly.
> > The bad news is that the problem was not in the varargs implementation,
> > but its use.
> >
> > You used to call vsnprintf twice.  Once to find out how much buffer would
> > be needed, then the second time for real. You can't do that without
> > reseting ap.
>
> ah right, i fixed this issue in vasprintf() some time ago.

I rsynced the tree yesterday. It was not fixed there. Today I see a va_copy 
for ap. When did you fix it? There is really no point in me spending a few 
hours on debugging stuff that you fixed some time ago.

> > The appended patch proposes a fix.
> > Btw: You said you'd tested that with LD_PRELOAD? What happend?
>
> vfprintf is blacklisted from prom-libc.so since the FILE stuff
> interferes with glibc.  (pretty much all of stdio is blacklisted,
> thats what the SOOBJS is in the Rules files).

Ok, that puts it into perspective. At least I know what has not been tested.
BTW: I rsynced today again. Am I now looking at the current stuff, or am I 
still working on old code?

...
>
> im fixing it differently since i don't want a large buf array around
> persistently

Here is the point: I feel like an idiot now, but am almost intimidated enough 
not to ask, but here it goes: what are you talking about? What array is 
around persistently? I am not trying to be annoying, I really don't get it.

-- 
Remco Treffkorn (RT445)
HAM DC2XT
remco@rvt.com   (831) 685-1201