[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: open.c



On Wed, Sep 24, 2003 at 06:18:16PM -0400, Pisupati, Ajay wrote:
> Ethan,
> 	I have started working on this again (atleast for a little while).
> Please take a look at the attached file and tell me what you think. 
> 
> of course, I had to make changes to the other files (commenting out some
> parts etc) but what's in this file works.
> and it is no where near completion.
> 
> Questions:
> [1] rawio.c 
> 	rawio.seek = rawio_seek [79] 
> 	problem is that there is no seek function prototype in __fsdriver.h.
> did you forget to include it? 

i didn't write that code, i wrote rawio.c, and i may have attempted to
start wiring it into the header files, but never really got anywhere.

as ive mentioned the codebase your working with is woefully
incomplete, the original author won't send his completed version.

when you find stuff missing you just need to finish it yourself..

> 	int rawio_open (struct __fd *file, int oflags, int mode)
> 	But the function prototype is listed as
> 	int (*open)(struct __fd *,int)
> 	which one is the correct one?

int rawio_open (struct __fd *file, int oflags, int mode)

remember we are implementing the posix calls, open() include a mode
argument.  even though we won't need it in most cases.

> [2] ofdevice.c 
> 	/* must start with http:// */
>         if (strncmp(path, "http://";, strlen("http://";)))
>                 return 0;
> 	I don't understand these lines. why should it start w/ http:// if it
> is an ofdevice?  did I completely 
>   	misunderstand what you were trying to do?	

don't ask me, ask the original author who actually wrote that (he is
snaund on freenode.net, don't expect any answers though).

everything in that vfs.tar.gz file is written by Kim Saunders, except
for rawio.c and ext2.c which were written by me.

i honestly don't understand Kim's code any better then you do, i just
understand the design concept its vaguly trying to implement (which
ive explained already).

you might want to look at Andrew Over's start of his own
implementation, at http://penguinppc.org/~eb/vfs2.tar.gz  its also
just as preliminary and incomplete.  unfortunatly Andrew Over has been
abducted by aliens never to be heard from again.

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgp00005.pgp
Description: PGP signature